Davis-Zhang-Onehouse commented on code in PR #13489:
URL: https://github.com/apache/hudi/pull/13489#discussion_r2174079841
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -466,14 +419,33 @@ private void
checkForSpuriousDeletes(HoodieMetadataPayload metadataPayload, Stri
}
}
+ /**
+ * Retrieves a single record from the metadata table by its key.
+ *
+ * @param key The escaped/encoded key to look up in the metadata table
+ * @param partitionName The partition name where the record is stored
+ * @return Option containing the record if found, empty Option if not found
+ */
protected abstract Option<HoodieRecord<HoodieMetadataPayload>>
getRecordByKey(String key, String partitionName);
- protected abstract Map<String, HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeys(List<String> keys, String partitionName);
+ /**
+ * Retrieves a map of (key -> record) from the metadata table by its keys.
+ *
+ * @param keys The to look up in the metadata table
+ * @param partitionName The partition name where the records are stored
+ * @return A map of (key -> record)
+ */
+ public abstract HoodiePairData<String, HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeysWithMapping(
Review Comment:
It make sense, let me take a note on this and interface renaming I will wait
for Vinoth to also confirm. Will keep the comment open until I do the rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
