linliu-code commented on code in PR #13498:
URL: https://github.com/apache/hudi/pull/13498#discussion_r2175491634
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -269,9 +277,13 @@ protected Option<BufferedRecord<T>>
doProcessNextDataRecord(BufferedRecord<T> ne
} else {
switch (recordMergeMode) {
case COMMIT_TIME_ORDERING:
+ updatePartiallyIfNeeded(
+ newRecord, existingRecord, readerSchema, readerSchema,
partialUpdateMode);
return Option.of(newRecord);
case EVENT_TIME_ORDERING:
if (shouldKeepNewerRecord(existingRecord, newRecord)) {
+ updatePartiallyIfNeeded(
Review Comment:
Based on the logic of current payload class, if the old record has higher
ordering value, it will pick from new records if the field from old record
satisfies some condition, like == default value. So for partial update of
payload class, there is no time concept, only base record and update record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
