Davis-Zhang-Onehouse commented on code in PR #13489:
URL: https://github.com/apache/hudi/pull/13489#discussion_r2178649658
##########
hudi-common/src/main/java/org/apache/hudi/metadata/FileSystemBackedTableMetadata.java:
##########
@@ -309,18 +311,21 @@ public Map<Pair<String, String>,
List<HoodieMetadataColumnStats>> getColumnStats
}
@Override
- public HoodieData<HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeyPrefixes(List<String> keyPrefixes, String partitionName, boolean
shouldLoadInMemory) {
+ public HoodieData<HoodieRecord<HoodieMetadataPayload>>
getRecordsByKeyPrefixes(HoodieData<String> keyPrefixes,
+
String partitionName,
+
boolean shouldLoadInMemory,
+
Option<SerializableFunction<String, String>> keyEncoder) {
throw new HoodieMetadataException("Unsupported operation:
getRecordsByKeyPrefixes!");
}
@Override
- public Map<String, HoodieRecordGlobalLocation> readRecordIndex(List<String>
recordKeys) {
- throw new HoodieMetadataException("Unsupported operation:
readRecordIndex!");
+ public HoodiePairData<String, HoodieRecordGlobalLocation>
readRecordIndexWithMapping(HoodieData<String> recordKeys) {
Review Comment:
done in commit "rename index lookup interface API"
the ones that takes keys as input and output key -> location pair, we still
use the old name
for ones that takes keys as input and output location only, we suffix
"Result", e.g. readRecordIndexResult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
