cshuo commented on code in PR #13511:
URL: https://github.com/apache/hudi/pull/13511#discussion_r2181237113
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/KeyBasedFileGroupRecordBuffer.java:
##########
@@ -67,12 +68,6 @@ public BufferType getBufferType() {
public void processDataBlock(HoodieDataBlock dataBlock, Option<KeySpec>
keySpecOpt) throws IOException {
Pair<ClosableIterator<T>, Schema> recordsIteratorSchemaPair =
getRecordsIterator(dataBlock, keySpecOpt);
- if (dataBlock.containsPartialUpdates()) {
- // When a data block contains partial updates, subsequent record merging
must always use
Review Comment:
> if we have 4 log files and only if 4th file contains partial merges, we
merge 3 log files as full record and only do partial merge for 4th log file
record processing.
That's also a point I'd like to confirm with @yihua , if the case is a valid
one, we cannot instantiate the partial update merger in the constructor of
`FileGroupRecordBuffer` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
