lokeshj1703 commented on code in PR #12340: URL: https://github.com/apache/hudi/pull/12340#discussion_r2182128567
########## hudi-common/src/test/java/org/apache/hudi/common/table/read/TestFileGroupReaderSchemaHandler.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.table.read; + +import org.apache.hudi.common.config.RecordMergeMode; +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.table.HoodieTableConfig; +import org.apache.hudi.common.util.collection.Pair; + +import org.apache.avro.Schema; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.stream.Stream; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class TestFileGroupReaderSchemaHandler extends SchemaHandlerTestBase { + + @Test + public void testCow() { + HoodieReaderContext<String> readerContext = mockReaderContext(false, false, false, false, null); + HoodieTableConfig hoodieTableConfig = mock(HoodieTableConfig.class); + Schema requestedSchema = DATA_SCHEMA; + FileGroupReaderSchemaHandler schemaHandler = createSchemaHandler(readerContext, DATA_SCHEMA, requestedSchema, hoodieTableConfig, false); + assertEquals(requestedSchema, schemaHandler.getRequiredSchema()); + + //read subset of columns + requestedSchema = generateProjectionSchema("begin_lat", "tip_history", "rider"); + schemaHandler = createSchemaHandler(readerContext, DATA_SCHEMA, requestedSchema, hoodieTableConfig, false); + assertEquals(requestedSchema, schemaHandler.getRequiredSchema()); + when(readerContext.getNeedsBootstrapMerge()).thenReturn(false); Review Comment: I had to do this to address Tim's comment on mocking the reader context. Did not know the bootstrap merge is set in the handler. I have reverted the mock related changes for reader context. There are test cases failing here when merge mode is custom and isProjectionCompatible is true for testMorBootstrap. Can you please help in debugging those? I am not sure why it is expected for bootstrap merge to be false in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
