xushiyan commented on code in PR #391:
URL: https://github.com/apache/hudi-rs/pull/391#discussion_r2185941565
##########
.github/workflows/code.yml:
##########
@@ -35,23 +35,26 @@ jobs:
- name: Check license header
uses: apache/skywalking-eyes/[email protected]
+ - name: Install uv
+ uses: astral-sh/setup-uv@v5
+ with:
+ version: "0.7.19"
+
- name: Check rust code style
run: make check-rust
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.9'
- cache: pip
- cache-dependency-path: python/pyproject.toml
- name: Install python linter dependencies
run: |
make setup-venv
- source venv/bin/activate
- pip install ruff==0.11.2 mypy==1.10.1
+ source .venv/bin/activate
+ uv pip install ruff==0.11.2 mypy==1.10.1
Review Comment:
We have been hard-coding the `ruff` and `mypy` versions here which should be
the same as those set in `pyproject.toml`.
While you're at this, would you be able to modify it to use the versions
from `pyproject.toml` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
