danny0405 commented on code in PR #13511: URL: https://github.com/apache/hudi/pull/13511#discussion_r2188872125
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMerger.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.read; + +import org.apache.hudi.common.model.DeleteRecord; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.Pair; + +import java.io.IOException; + +/** + * A {@link BufferedRecord} merger that covers three core merging scenarios within {@link FileGroupRecordBuffer}: + * + * <ol> + * <li>log & log merging;</li> + * <li>log & delete record merging;</li> + * <li>base & log merging.</li> + * </ol> + */ +public interface BufferedRecordMerger<T> { + + /** + * Merges incoming record from log file with existing record in record buffer. + * + * @param newRecord Incoming record from log file + * @param existingRecord Existing record in record buffer + * + * @return The merged record. + */ + Option<BufferedRecord<T>> deltaMerge(BufferedRecord<T> newRecord, BufferedRecord<T> existingRecord) throws IOException; Review Comment: An `Option.empty` indicates the existing buffered record is chosen, we need to consolidate the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
