danny0405 commented on code in PR #13473:
URL: https://github.com/apache/hudi/pull/13473#discussion_r2188902814
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -504,6 +505,7 @@ public static void recover(HoodieStorage storage,
StoragePath metadataFolder) th
private static void modify(HoodieStorage storage, StoragePath
metadataFolder, Properties modifyProps, BiConsumer<Properties, Properties>
modifyFn) {
StoragePath cfgPath = new StoragePath(metadataFolder,
HOODIE_PROPERTIES_FILE);
StoragePath backupCfgPath = new StoragePath(metadataFolder,
HOODIE_PROPERTIES_FILE_BACKUP);
+ StoragePath tempCfgPath = new StoragePath(metadataFolder,
HOODIE_PROPERTIES_FILE + HOODIE_TEMP_FILE_SUFFIX);
Review Comment:
> 3. SInce properties file is present but empty, we won't recover from
backup file and we will delete the backup file which contains the actual
properties.
Can we just fix 3 by checking whether the existing properties file contains
a checksum there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
