linliu-code commented on code in PR #13498:
URL: https://github.com/apache/hudi/pull/13498#discussion_r2190166300
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -263,15 +297,20 @@ protected Option<BufferedRecord<T>>
doProcessNextDataRecord(BufferedRecord<T> ne
// If pre-combine returns existing record, no need to update it
if (combinedRecord.getData() != existingRecord.getRecord()) {
- return Option.of(BufferedRecord.forRecordWithContext(combinedRecord,
combinedRecordAndSchema.getRight(), readerContext, props));
+ return Option.of(BufferedRecord.forRecordWithContext(
+ combinedRecord, combinedRecordAndSchema.getRight(),
readerContext, props));
}
return Option.empty();
} else {
switch (recordMergeMode) {
case COMMIT_TIME_ORDERING:
+ newRecord = updatePartiallyIfNeeded(
+ newRecord, existingRecord, readerSchema, readerSchema,
partialUpdateMode);
return Option.of(newRecord);
case EVENT_TIME_ORDERING:
if (shouldKeepNewerRecord(existingRecord, newRecord)) {
+ newRecord = updatePartiallyIfNeeded(
+ newRecord, existingRecord, readerSchema, readerSchema,
partialUpdateMode);
Review Comment:
yeah, we should. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
