yihua commented on code in PR #13444:
URL: https://github.com/apache/hudi/pull/13444#discussion_r2194119045
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -565,27 +570,62 @@ protected boolean hasNextBaseRecord(T baseRecord,
BufferedRecord<T> logRecordInf
Pair<Boolean, T> isDeleteAndRecord = merge(baseRecordInfo,
logRecordInfo);
if (!isDeleteAndRecord.getLeft()) {
// Updates
- nextRecord = readerContext.seal(isDeleteAndRecord.getRight());
+ nextRecord =
readerContext.seal(applyOutputSchemaConversion(isDeleteAndRecord.getRight()));
Review Comment:
If the performance is almost the same (here we are talking about nanosecond
differences), I think it's OK to keep the current shape of the PR and
prioritize the overall goal of unifying the CDC logic through the new FGReader.
We should keep the overall goal in mind without getting lost in a particular
debate where we already have data points that the current change does not bring
regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
