rmpifer commented on a change in pull request #2248:
URL: https://github.com/apache/hudi/pull/2248#discussion_r530206042
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkWriteHelper.java
##########
@@ -59,10 +59,9 @@ public static SparkWriteHelper newInstance() {
}).reduceByKey((rec1, rec2) -> {
@SuppressWarnings("unchecked")
T reducedData = (T) rec1.getData().preCombine(rec2.getData());
- // we cannot allow the user to change the key or partitionPath, since
that will affect
- // everything
- // so pick it from one of the records.
- return new HoodieRecord<T>(rec1.getKey(), reducedData);
+ HoodieKey reducedKey = rec1.getData().equals(reducedData) ?
rec1.getKey() : rec2.getKey();
Review comment:
Ya I see your point here. From the existing payload implementations
`precombine` either returned `this` or `other` so this seemed fine. But if
there was other payloads being used with merging behavior, default `HoodieKey`
would be set to `rec2.getKey()`. This could be solved by regenerating key here,
but there would be performance cost
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
