the-other-tim-brown commented on code in PR #13444:
URL: https://github.com/apache/hudi/pull/13444#discussion_r2203722193
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/HoodieFlinkMergeOnReadTableCompactor.java:
##########
@@ -69,35 +67,22 @@ public void preCompact(
}
}
- public List<WriteStatus> compact(HoodieCompactionHandler compactionHandler,
- HoodieWriteConfig writeConfig,
+ public List<WriteStatus> compact(HoodieWriteConfig writeConfig,
CompactionOperation operation,
String instantTime,
TaskContextSupplier taskContextSupplier,
- Option<HoodieReaderContext<?>>
readerContextOpt,
+ HoodieReaderContext<?> readerContext,
HoodieTable table) throws IOException {
String maxInstantTime = getMaxInstantTime(table.getMetaClient());
Review Comment:
Yes, the plan is to have all reads go through the FileGroupReader as our
common read path as part of the 1.1.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
