cshuo commented on code in PR #13543:
URL: https://github.com/apache/hudi/pull/13543#discussion_r2206114022
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -283,7 +257,7 @@ public void checkpointCoordinator(long checkpointId,
CompletableFuture<byte[]> r
executor.execute(
() -> {
try {
- result.complete(new byte[0]);
+
result.complete(SerializationUtils.serialize(this.eventBuffers.getAllEvents()));
Review Comment:
Yes, there is no correctness issue here, and it's about duplicate
checkpointing. The `ckpId` actually satisfies `< checkpointId`, since there may
exists eager flushing in writers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
