danny0405 commented on code in PR #13544:
URL: https://github.com/apache/hudi/pull/13544#discussion_r2209052809
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -106,25 +107,26 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext, HoodieStorage
Option<InternalSchema> internalSchemaOpt, HoodieTableMetaClient
hoodieTableMetaClient,
TypedProperties props,
long start, long length, boolean shouldUseRecordPosition) {
- this(readerContext, storage, tablePath, latestCommitTime, fileSlice,
dataSchema,
+ this(readerContext, storage, tablePath, latestCommitTime, dataSchema,
requestedSchema, internalSchemaOpt, hoodieTableMetaClient, props,
start, length,
- shouldUseRecordPosition, false, false, false);
+ shouldUseRecordPosition, false, false, false, fileSlice.getBaseFile(),
fileSlice.getLogFiles(), fileSlice.getPartitionPath());
}
private HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
HoodieStorage storage, String tablePath,
- String latestCommitTime, FileSlice fileSlice,
Schema dataSchema, Schema requestedSchema,
+ String latestCommitTime, Schema dataSchema,
Schema requestedSchema,
Option<InternalSchema> internalSchemaOpt,
HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
- long start, long length, boolean
shouldUseRecordPosition, boolean allowInflightInstants, boolean emitDelete,
boolean sortOutput) {
+ long start, long length, boolean
shouldUseRecordPosition, boolean allowInflightInstants, boolean emitDelete,
boolean sortOutput,
+ Option<HoodieBaseFile> baseFileOption,
Stream<HoodieLogFile> logFiles, String partitionPath) {
Review Comment:
The params is super large now, can we have an abstraction like
`HoodieInputSplit` to encapsulate these three: `Option<HoodieBaseFile>
baseFileOption, Stream<HoodieLogFile> logFiles, String partitionPath`. Probably
also these two: `long start, long length`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
