nsivabalan commented on code in PR #13521:
URL: https://github.com/apache/hudi/pull/13521#discussion_r2211586708
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -287,12 +293,14 @@ private HoodiePairData<String,
HoodieRecord<HoodieMetadataPayload>> doLookup(Hoo
// SI write path concatenates secKey$recordKey, the secKey needs extracted
for hashing;
// SI read path gives secKey only, no need for secKey extraction.
SerializableBiFunction<String, Integer, Integer> mappingFunction =
HoodieTableMetadataUtil::mapRecordKeyToFileGroupIndex;
- keys = repartitioningIfNeeded(keys, partitionName, numFileSlices,
mappingFunction);
+ keys = repartitioningIfNeeded(keys, partitionName, numFileSlices,
mappingFunction, keyEncodingFn);
Review Comment:
why we special case `isSecondaryIndex`.
even col stats will be have to do prefix lookup.
oh, I see that col stats go through `getRecordsByKeyPrefixes` which has a
diff code path.
then, curious as to why SI does not go that route or whats the need for SI
to call into `getRecordsByKeys`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
