geserdugarov opened a new pull request, #13570:
URL: https://github.com/apache/hudi/pull/13570

   ### Change Logs
   
   Currently, we call `RowDataKeyGen::instance` from almost everywhere, and 
only in one place do we call `RowDataKeyGens::instance`. However, 
`RowDataKeyGens::instance` was intended to be the branching point based on 
table configuration, where the appropriate type of keygen is selected. This PR 
fixes that by making `RowDataKeyGens::instance` the common entry point and 
switching access to `RowDataKeyGen::instance` to package-private to prevent 
future misuse.
   
   ### Impact
   
   Refactor keygen instantiation for Flink.
   
   ### Risk level (write none, low medium or high below)
   
   No
   
   ### Documentation Update
   
   No need
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to