yihua commented on code in PR #13558:
URL: https://github.com/apache/hudi/pull/13558#discussion_r2216883612
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala:
##########
@@ -378,4 +378,17 @@ object HoodieSqlCommonUtils extends SparkAdapterSupport {
throw new HoodieException(s"Got an invalid instant ($queryInstant)")
}
}
+
+ /**
+ * Check if Polaris catalog is enabled in the Spark session.
+ * @param sparkSession The Spark session
+ * @return true if Polaris catalog is configured, false otherwise
+ */
+ def isUsingPolarisCatalog(sparkSession: SparkSession): Boolean = {
Review Comment:
This is good enough for now. In the future, can this be change to a general
check on V2 catalog implementation, instead of a specific catalog
implementation class like Polaris, so other V2 catalog implementation class can
also be used?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala:
##########
@@ -378,4 +378,17 @@ object HoodieSqlCommonUtils extends SparkAdapterSupport {
throw new HoodieException(s"Got an invalid instant ($queryInstant)")
}
}
+
+ /**
+ * Check if Polaris catalog is enabled in the Spark session.
+ * @param sparkSession The Spark session
+ * @return true if Polaris catalog is configured, false otherwise
+ */
+ def isUsingPolarisCatalog(sparkSession: SparkSession): Boolean = {
+ sparkSession.conf.getAll.exists { case (key, value) =>
+ key.startsWith("spark.sql.catalog.") &&
+ value == "org.apache.polaris.spark.SparkCatalog"
+ }
+ }
+
Review Comment:
nit: remove redundant empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
