linliu-code commented on code in PR #13533:
URL: https://github.com/apache/hudi/pull/13533#discussion_r2217385494
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestCommonClientUtils.java:
##########
@@ -95,14 +95,13 @@ private static Stream<Arguments>
provideValidTableVersionWriteVersionPairs() {
generateSameVersionCases()
),
Stream.of(
- // Rule 3: special case - upgrade scenario (table > 6, table < 9,
writer = 6)
+ // Rule 3: downgrade scenarios
Arguments.of(HoodieTableVersion.SEVEN, HoodieTableVersion.SIX,
true),
Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SIX,
true),
-
- // Rule 4: otherwise disallowed - table > writer (except special
case above)
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX,
false),
- Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.EIGHT,
false),
- Arguments.of(HoodieTableVersion.EIGHT, HoodieTableVersion.SEVEN,
false)
+ Arguments.of(HoodieTableVersion.NINE, HoodieTableVersion.SIX,
true),
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
