linliu-code commented on code in PR #13580:
URL: https://github.com/apache/hudi/pull/13580#discussion_r2217489717
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -66,6 +85,10 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O>
create(
if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
return new HoodieMergeHandleWithChangeLog<>(writeConfig, instantTime,
table, recordItr, partitionPath, fileId, taskContextSupplier, keyGeneratorOpt);
} else {
+ if (readerContextOpt.isPresent()) {
+ return new FileGroupReaderBasedMergeHandle<>(
Review Comment:
We can remove it from HoodieMergeHandle from this factory after this patch.
I just want to be safe, and plug it to spark for now. I am trying to fix the
failures and make it work for spark first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
