danny0405 commented on code in PR #13517:
URL: https://github.com/apache/hudi/pull/13517#discussion_r2218032862


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -161,7 +164,21 @@ public Pair<Boolean, T> finalMerge(BufferedRecord<T> 
olderRecord,
    * An implementation of {@link BufferedRecordMerger} which merges {@link 
BufferedRecord}s
    * based on {@code EVENT_TIME_ORDERING} merge mode.
    */
-  private static class EventTimeBufferedRecordMerger<T> implements 
BufferedRecordMerger<T> {
+  static class EventTimeBufferedRecordMerger<T> implements 
BufferedRecordMerger<T> {

Review Comment:
   Add a new `BufferedRecordMerger` to avoid unnecessary cost for row-level 
option `hoodie.write.track.event.time.watermark` check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to