danny0405 commented on code in PR #13544:
URL: https://github.com/apache/hudi/pull/13544#discussion_r2218125029
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -570,15 +564,42 @@ public HoodieFileGroupReader<T> build() {
ValidationUtils.checkArgument(storage != null, "Storage is required");
ValidationUtils.checkArgument(latestCommitTime != null, "Latest commit
time is required");
- ValidationUtils.checkArgument(fileSlice != null, "File slice is
required");
ValidationUtils.checkArgument(dataSchema != null, "Data schema is
required");
ValidationUtils.checkArgument(requestedSchema != null, "Requested schema
is required");
ValidationUtils.checkArgument(props != null, "Props is required");
+ ValidationUtils.checkArgument(baseFileOption != null, "Base file option
is required");
+ ValidationUtils.checkArgument(logFiles != null, "Log files stream is
required");
+ ValidationUtils.checkArgument(partitionPath != null, "Partition path is
required");
-
+ InputSplit inputSplit = new InputSplit(baseFileOption, logFiles,
partitionPath, start, length);
return new HoodieFileGroupReader<>(
- readerContext, storage, tablePath, latestCommitTime, fileSlice,
dataSchema, requestedSchema, internalSchemaOpt, hoodieTableMetaClient, props,
- start, length, shouldUseRecordPosition, allowInflightInstants,
emitDelete, sortOutput, fileGroupUpdateCallback, enableOptimizedLogBlockScan);
+ readerContext, storage, tablePath, latestCommitTime, dataSchema,
requestedSchema, internalSchemaOpt, hoodieTableMetaClient,
+ props, shouldUseRecordPosition, allowInflightInstants, emitDelete,
sortOutput, inputSplit, fileGroupUpdateCallback, enableOptimizedLogBlockScan);
+ }
+ }
+
+ private static class InputSplit {
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
