lokeshj1703 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2218397802
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/HoodieCDCRDD.scala:
##########
@@ -137,24 +139,14 @@ class HoodieCDCRDD(
keyFields.head
}
- private lazy val preCombineFieldOpt: Option[String] =
Option(metaClient.getTableConfig.getPreCombineField)
+ private lazy val preCombineFieldsOpt: Option[List[String]] =
convertHudiOptionToScalaOption(metaClient.getTableConfig.getPreCombineFieldList
+ .map[List[String]](list => list.asScala.toList))
private lazy val tableState = {
val metadataConfig = HoodieMetadataConfig.newBuilder()
.fromProperties(props)
.build()
- HoodieTableState(
- basePath.toUri.toString,
- Some(split.changes.last.getInstant),
- recordKeyField,
- preCombineFieldOpt,
- usesVirtualKeys = !populateMetaFields,
- metaClient.getTableConfig.getPayloadClass,
- metadataConfig,
- // TODO support CDC with spark record
- recordMergeImplClasses = List(classOf[HoodieAvroRecordMerger].getName),
- recordMergeStrategyId =
HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID
- )
+ HoodieTableState(basePath.toUri.toString,
Some(split.changes.last.getInstant), recordKeyField, preCombineFieldsOpt,
usesVirtualKeys = !populateMetaFields,
metaClient.getTableConfig.getPayloadClass, metadataConfig,
recordMergeImplClasses = List(classOf[HoodieAvroRecordMerger].getName),
recordMergeStrategyId = HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID)
Review Comment:
Unintentional change. Reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
