the-other-tim-brown commented on code in PR #13556:
URL: https://github.com/apache/hudi/pull/13556#discussion_r2219256441
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java:
##########
@@ -186,7 +187,7 @@ private FileSlice
getFileSliceFromOperation(CompactionOperation operation, Strin
return new FileSlice(
operation.getFileGroupId(),
operation.getBaseInstantTime(),
- baseFileOpt.isPresent() ? baseFileOpt.get() : null,
+ operationType == WriteOperationType.LOG_COMPACT ||
baseFileOpt.isEmpty() ? null : baseFileOpt.get(),
Review Comment:
I've updated the code to avoid the confusion. The FGReader now has options
to specify the base file, log files, and partition directly instead of
constructing the file slice so I am using those now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
