vinothchandar commented on a change in pull request #2266:
URL: https://github.com/apache/hudi/pull/2266#discussion_r532820609
##########
File path:
hudi-client/src/main/java/org/apache/hudi/metadata/FSBackedTableMetadataWriter.java
##########
@@ -74,84 +60,109 @@
import org.apache.hudi.exception.HoodieMetadataException;
import org.apache.hudi.metrics.DistributedRegistry;
import org.apache.hudi.table.HoodieTable;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
import org.apache.spark.api.java.JavaPairRDD;
import org.apache.spark.api.java.JavaRDD;
import org.apache.spark.api.java.JavaSparkContext;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+
import scala.Tuple2;
+import static
org.apache.hudi.metadata.HoodieTableMetadata.METADATA_TABLE_NAME_SUFFIX;
+import static
org.apache.hudi.metadata.HoodieTableMetadata.NON_PARTITIONED_NAME;
+import static
org.apache.hudi.metadata.HoodieTableMetadata.SOLO_COMMIT_TIMESTAMP;
+
/**
* Writer for Metadata Table.
*
* Partition and file listing are saved within an internal MOR table called
Metadata Table. This table is created
* by listing files and partitions (first time) and kept in sync using the
instants on the main dataset.
*/
-public class HoodieMetadataWriter extends HoodieMetadataReader implements
Serializable {
- private static final Logger LOG =
LogManager.getLogger(HoodieMetadataWriter.class);
+public class FSBackedTableMetadataWriter implements HoodieTableMetadataWriter {
Review comment:
Good point. Call it - `HoodieBackedTableMetadataWriter`? wdyt
@prashantwason
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
