Davis-Zhang-Onehouse commented on code in PR #13489: URL: https://github.com/apache/hudi/pull/13489#discussion_r2220130158
########## hudi-common/src/main/java/org/apache/hudi/common/util/collection/ClosableSortingIterator.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.util.collection; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; + +/** + * Iterator that provides sorted elements from a source iterator. + * Elements are sorted using natural ordering if they implement Comparable. + * If sorting fails or elements are not Comparable, the original order is preserved. + * This iterator is closable and will close the underlying iterator if it implements AutoCloseable. + * + * @param <T> Type of elements + */ +public class ClosableSortingIterator<T> implements Iterator<T>, AutoCloseable { + private final Iterator<T> source; + private final boolean closable; + private Iterator<T> sortedIterator; + private boolean initialized = false; + + public ClosableSortingIterator(Iterator<T> source) { + this.source = source; + this.closable = source instanceof AutoCloseable; + } + + @Override + public boolean hasNext() { + initializeIfNeeded(); + return sortedIterator.hasNext(); + } + + @Override + public T next() { + initializeIfNeeded(); + return sortedIterator.next(); + } + + @Override + public void close() throws Exception { + if (closable) { + ((AutoCloseable) source).close(); + } + } + + private void initializeIfNeeded() { + if (!initialized) { + // Collect all elements from the source iterator + List<T> list = new ArrayList<>(); + source.forEachRemaining(list::add); + + // If the list is empty or has only one element, no sorting needed + if (list.size() <= 1) { + sortedIterator = list.iterator(); + } else { + // Check if the first element is Comparable + T firstElement = list.get(0); + if (firstElement instanceof Comparable) { + try { + // Sort the list using natural ordering + Collections.sort((List) list); + } catch (Exception e) { + // If sorting fails (e.g., ClassCastException), keep original order Review Comment: revised to error out if value is not sortable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
