Davis-Zhang-Onehouse commented on code in PR #13523:
URL: https://github.com/apache/hudi/pull/13523#discussion_r2220264987
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java:
##########
@@ -57,6 +57,9 @@ public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsByKeysIterator(
public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsByKeyPrefixIterator(
List<String> sortedKeyPrefixes, Schema readerSchema) throws IOException;
+ public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsBySecondaryIndexKeyMatcherIterator(
Review Comment:
removed
##########
hudi-common/src/main/java/org/apache/hudi/expression/PartialBindVisitor.java:
##########
@@ -133,6 +133,24 @@ public Expression visitPredicate(Predicate predicate) {
}
}
+ if (predicate instanceof Predicates.SecondaryIndexKeyMatcher) {
Review Comment:
revised the implementation completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
