danny0405 commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2224122784
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -217,6 +218,7 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tablePath: String,
.withStart(file.start)
.withLength(baseFileLength)
.withShouldUseRecordPosition(shouldUseRecordPosition)
+
.withEnableOptimizedLogBlockScan(props.getBoolean(HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.key(),
HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.defaultValue().toBoolean))
Review Comment:
if the option key is already in the props, we can add a fallback logic in
the FG reader builder:
```java
if (withEnableOptimizedLogBlockScan == null) {
withEnableOptimizedLogBlockScan =
props.getBoolean(HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.key(),
HoodieReaderConfig.ENABLE_OPTIMIZED_LOG_BLOCKS_SCAN.defaultValue().toBoolean)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
