danny0405 commented on code in PR #13594:
URL: https://github.com/apache/hudi/pull/13594#discussion_r2224140202


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2469,6 +2469,63 @@ public static boolean 
validateDataTypeForSecondaryOrExpressionIndex(List<String>
     });
   }
 
+  /**
+   * Given table schema and fields to index, checks if each field's data type 
are supported for secondary index.
+   * Secondary index has stricter requirements than expression index.
+   *
+   * @param sourceFields fields to index
+   * @param tableSchema  table schema
+   * @return true if each field's data type are supported for secondary index, 
false otherwise
+   */
+  public static boolean validateDataTypeForSecondaryIndex(List<String> 
sourceFields, Schema tableSchema) {

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to