n3nash commented on a change in pull request #2263:
URL: https://github.com/apache/hudi/pull/2263#discussion_r533658804
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertMapFunction.java
##########
@@ -41,20 +41,22 @@
private HoodieWriteConfig config;
private HoodieTable hoodieTable;
private List<String> fileIDPrefixes;
+ private boolean addMetadataFields;
public BulkInsertMapFunction(String instantTime, boolean areRecordsSorted,
HoodieWriteConfig config, HoodieTable
hoodieTable,
- List<String> fileIDPrefixes) {
+ List<String> fileIDPrefixes, boolean
addMetadataFields) {
Review comment:
This problem exists today with the MOR tables when inserts go into log
files. For this reason, we have a different constructor for the create handle
that is called from the compaction code path ->
https://github.com/apache/hudi/blob/36ce5bcd92fa6cb2fb88677eae1a7a846f606e3f/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java#L93.
Can you try to do the same for clustering and avoid passing this flag here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
