TheR1sing3un commented on code in PR #13606:
URL: https://github.com/apache/hudi/pull/13606#discussion_r2228162581
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##########
@@ -256,6 +260,25 @@ private List<HoodieInstant> getCommitInstantsToArchive()
throws IOException {
earliestInstantToRetainCandidates.add(qualifiedEarliestInstant);
}
+ // 6. If archival should consider `earliest retain instant` in the clean
plan,
+ // we should add the earliest retain instant from the clean plan to the
candidates.
+ if (config.shouldArchiveKeepCleanPlanRetainInstant()) {
Review Comment:
> it is resolved in `ClusteringUtils.getEarliestInstantToRetainForClustering`
These two logics are not equivalent. In method
`ClusteringUtils.getEarliestInstantToRetainForClustering`, it is only to find
the first `clustering` instant that is larger than or equals to `retain
instant` as a candidate.
<img width="1450" height="814" alt="image"
src="https://github.com/user-attachments/assets/c723cffe-5597-45f9-86b6-e062f3efa895";
/>
It is not equivalent to directly using `retain instant` as a candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
