the-other-tim-brown commented on code in PR #13602:
URL: https://github.com/apache/hudi/pull/13602#discussion_r2228861240
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -116,6 +122,8 @@ public class HoodieBackedTableMetadata extends
BaseTableMetadata {
private HoodieTableFileSystemView metadataFileSystemView;
// should we reuse the open file handles, across calls
private final boolean reuse;
+ private final transient Map<HoodieFileGroupId, Pair<HoodieAvroFileReader,
FileGroupRecordBufferInitializer.ReusableFileGroupRecordBufferInitializer<IndexedRecord>>>
reusableFileReaders
Review Comment:
Right now this fixes the "reuse" where we are keeping parity with how this
was working before where we reuse the reader object. The reader object will
always read from the file system again though right now because the reader does
not have any block cache implemented with the native HFile reader. The
assumption is that this gap will be handled in the `HoodieAvroFileReader`
implementation so it "just works" here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
