yui2010 opened a new pull request #2292: URL: https://github.com/apache/hudi/pull/2292
## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the pull request fix clean old fileslice is invalid Reproduce : Table type MERGE_ON_READ and set hoodie.cleaner.commits.retained=2 Do insert into table three times into same partition And it will create follow parquet file a2c57b73-5ba9-4744-9027-640075a179ec-0_0-213-1740_20201201200149.parquet a2c57b73-5ba9-4744-9027-640075a179ec-0_0-176-1702_20201201195638.parquet a2c57b73-5ba9-4744-9027-640075a179ec-0_0-139-1664_20201201195219.parquet a2c57b73-5ba9-4744-9027-640075a179ec-0_0-103-1632_20201201193835.parquet And 20201201200149.parquet is newest The old parquet files have not be deleted when do client.clean() The reason is CleanPlanner init commitTimeline with hoodieTable.getCompletedCommitTimeline(); And getCompletedCommitTimeline method not include DELTA_COMMIT_ACTION ## Brief change log using hoodieTable.getCompletedCommitsTimeline() replace hoodieTable.getCompletedCommitTimeline() ## Verify this pull request *(Please pick either of the following options)* This pull request is a trivial rework / code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
