nsivabalan commented on code in PR #13616:
URL: https://github.com/apache/hudi/pull/13616#discussion_r2229833021
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -321,14 +321,13 @@ public class HoodieTableConfig extends HoodieConfig {
.withDocumentation("This property when set, will define how two versions
of the record will be "
+ "merged together where the later contains only partial set of
values and not entire record.");
- public static final ConfigProperty<String> MERGE_PROPERTIES = ConfigProperty
- .key("hoodie.table.merge.properties")
+ public static final ConfigProperty<String> MERGE_CUSTOM_PROPERTY_PREFIX =
ConfigProperty
+ .key("hoodie.merge.custom.property.prefix")
Review Comment:
`hoodie.table.merge.properties.`
and why do we need this to be a Config Property in itself.
we just need to declare this as constant variable here.
Lets see how this pan out:
In HoodieTableMetaClient.TableBuilder, lets add a new method called
`addCustomMergeProperties(Map<String, String> customProperties)`
in the impl, we process these properties and write them out as N diff
properties w/ the prefix (constant) string declared
("hoodie.table.merge.properties.").
Something like
```
hoodie.table.merge.properties.k1 = v1
hoodie.table.merge.properties.k2 = v2
```
And this will get serialized to hoodie.properties.
We should have a getter method in
HoodieTableConfig.getCustomMergeProperties(),
we should process all properties w/ above prefix and return a Map<String,
String> by stripping of the prefix string for each key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
