nsivabalan commented on code in PR #13613:
URL: https://github.com/apache/hudi/pull/13613#discussion_r2229837094
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/ReaderContextTypeConverter.java:
##########
@@ -20,14 +20,16 @@
package org.apache.hudi.common.engine;
/**
- * Helper class that handle cell level operation.
+ * An interface that implements type conversion related functions,
+ * which is expected to extended by different engines to
+ * handle their type conversion accordingly.
*/
-public class ReaderContextTypeConverter {
+public interface ReaderContextTypeConverter {
Review Comment:
can we have a `BaseReaderContextTypeConverter` which is concrete class and
implements this interface.
##########
hudi-common/src/test/java/org/apache/hudi/common/engine/TestReaderContextTypeConverter.java:
##########
@@ -58,4 +58,8 @@ void testCastToString_withNonNullValue() {
void testCastToString_withNullValue() {
assertNull(typeHandler.castToString(null));
}
+
+ static class DefaultReaderContextTypeConverter implements
ReaderContextTypeConverter {
Review Comment:
why not declare this in source code only and use it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
