linliu-code commented on code in PR #13623:
URL: https://github.com/apache/hudi/pull/13623#discussion_r2230954096
##########
hudi-common/src/main/java/org/apache/hudi/common/table/PartialUpdateMode.java:
##########
@@ -22,28 +22,24 @@
import org.apache.hudi.common.config.EnumFieldDescription;
public enum PartialUpdateMode {
- @EnumFieldDescription(
- "No partial update logic should be employed.")
- NONE,
-
@EnumFieldDescription(
"For any column values missing in current record, pick value from
previous version of the record.")
KEEP_VALUES,
- @EnumFieldDescription(
- "For column values missing in current record, pick the default value
from the schema.")
- FILL_DEFAULTS,
-
@EnumFieldDescription(
"For columns having default values set in current record, pick the value
from previous version of the record."
- + "Only top level data type default is checked, which means this mode
does not check leaf level data type default"
- + "value for nested data types.")
+ + "Only top level data type default is checked, which means this
mode does not check leaf level data type default"
+ + "value for nested data types.")
IGNORE_DEFAULTS,
@EnumFieldDescription(
- "For columns having marker in the current record, pick value from
previous version of the record during write."
- + "Marker value can be defined using
`hoodie.write.partial.update.custom.marker`, which should be added to"
- + "the value of table config `hoodie.write.partial.update.properties`.
During upgrade, it could be"
- + "added automatically for some payload classes, e.g.,
`PostgresDebeziumAvroPayload`.")
- IGNORE_MARKERS
+ "For columns having default values or nulls set in current record, pick
the value from previous version of the record."
+ + "Only top level data type default is checked, which means this
mode does not check nested fields.")
+ IGNORE_DEFAULTS_NULLS,
Review Comment:
Both `OverwriteNonDefaultsWithLatestAvroPayload` and
`PartialUpdateAvroPayload` uses `IGNORE_DEFAULTS`. Not sure which payloads uses
`IGNORE_DEFAULTS_NULLS` mode. Meanwhile, default value of most columns are
NULL. so, not sure the real difference between this two modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
