nsivabalan commented on code in PR #13498: URL: https://github.com/apache/hudi/pull/13498#discussion_r2231765667
########## hudi-common/src/main/java/org/apache/hudi/common/engine/ReaderContextTypeConverter.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.engine; + +/** + * Helper class that handle cell level operation. + */ +public class ReaderContextTypeConverter { Review Comment: Addressed as part of https://github.com/apache/hudi/pull/13613 ########## hudi-common/src/main/java/org/apache/hudi/avro/AvroReaderContextTypeConverter.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.common.engine.ReaderContextTypeConverter; +import org.apache.hudi.common.util.StringUtils; + +import java.nio.ByteBuffer; + +public class AvroReaderContextTypeConverter extends ReaderContextTypeConverter { Review Comment: Addressed as part of https://github.com/apache/hudi/pull/13613 ########## hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java: ########## @@ -410,6 +403,18 @@ public Comparable getOrderingValue(T record, */ public abstract HoodieRecord<T> constructHoodieRecord(BufferedRecord<T> bufferedRecord); + /** + * Constructs a new Engine based record based on a given schema, base record and update values. + * + * @param schema The schema of the new record. + * @param updateValues The map recording field index and its corresponding update value. + * @param baseRecord The record based on which the engine record is built. + * @return A new instance of engine record type {@link T}. + */ + public abstract T constructEngineRecord(Schema schema, Review Comment: Addressed as part of https://github.com/apache/hudi/pull/13613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
