rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2231752660
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2563,7 +2583,8 @@ public static HoodieData<HoodieRecord>
convertFilesToPartitionStatsRecords(Hoodi
HoodieMetadataConfig metadataConfig,
HoodieTableMetaClient dataTableMetaClient,
Lazy<Option<Schema>> lazyWriterSchemaOpt,
-
Option<HoodieRecordType> recordTypeOpt) {
+
Option<HoodieRecordType> recordTypeOpt,
+
boolean enableOptimizeLogBlocksScan) {
Review Comment:
When tracing thru this code path it seems this specific method
`readRecordKeysFromFileSlices` is only used for tests
<img width="1786" height="284" alt="Screenshot 2025-07-25 at 11 15 43 AM"
src="https://github.com/user-attachments/assets/5a1cba43-97c0-4f94-ae23-f9f36c1de447";
/>
This method also seems to make its way thru to using the
`getFileGroupReaderPropertiesFromStorageConf`
https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java#L2428
which if we are ok with setting the value like so
https://github.com/apache/hudi/pull/13591/files#r2231723862 then I do not think
we need a similar parameter, as it will go thru the props fallback logic in the
builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
