yihua commented on code in PR #13626:
URL: https://github.com/apache/hudi/pull/13626#discussion_r2232294662


##########
hudi-common/src/test/java/org/apache/hudi/common/data/TestHoodieListDataPairData.java:
##########
@@ -153,7 +154,7 @@ public void testReduceByKey(Map<Integer, List<Integer>> 
expected, Map<Integer, L
 
   @Test
   void testReduceByKeyWithCloseableInput() {
-    List<CloseValidationIterator<Pair<Integer, Integer>>> createdIterators = 
new ArrayList<>();
+    ConcurrentLinkedQueue<CloseValidationIterator<Pair<Integer, Integer>>> 
createdIterators = new ConcurrentLinkedQueue<>();

Review Comment:
   Is there any similar pattern in production code where a non thread-safe list 
is used in paralleled operation?  Probably not since that would break more 
tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to