rahil-c commented on code in PR #13591:
URL: https://github.com/apache/hudi/pull/13591#discussion_r2232587528
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -420,7 +421,7 @@ public static Map<String, HoodieData<HoodieRecord>>
convertMetadataToRecords(Hoo
String instantTime, HoodieTableMetaClient dataMetaClient, HoodieTableMetadata
tableMetadata,
HoodieMetadataConfig metadataConfig, Set<String> enabledPartitionTypes, String
bloomFilterType,
int bloomIndexParallelism, int writesFileIdEncoding, EngineType engineType,
-
Option<HoodieRecordType> recordTypeOpt) {
+
Option<HoodieRecordType> recordTypeOpt, boolean enableOptimizeLogBlocksScan) {
Review Comment:
Will update the java doc with the context for this new param, and this I
believe is for the data table as it is passing in the `dataMetaClient` which I
believe corresponds to data table, as there is another meta client called
`metadataMetaClient` which corresponds to mdt table which is not being passed.
<img width="678" height="479" alt="Screenshot 2025-07-25 at 10 42 25 PM"
src="https://github.com/user-attachments/assets/52b4acd8-6e19-4313-a725-2fe2965f1e03";
/>
The java doc for this `convertMetadataToRecords` also mentions this `*
@param dataMetaClient - HoodieTableMetaClient for data`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
