linliu-code commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2232886020
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1476,13 +1477,21 @@ public Properties build() {
tableConfig.setTableVersion(tableVersion);
tableConfig.setInitialVersion(tableVersion);
- Triple<RecordMergeMode, String, String> mergeConfigs =
- HoodieTableConfig.inferCorrectMergingBehavior(
- recordMergeMode, payloadClassName, recordMergerStrategyId,
preCombineField,
- tableVersion);
- tableConfig.setValue(RECORD_MERGE_MODE, mergeConfigs.getLeft().name());
- tableConfig.setValue(PAYLOAD_CLASS_NAME.key(), mergeConfigs.getMiddle());
- tableConfig.setValue(RECORD_MERGE_STRATEGY_ID, mergeConfigs.getRight());
+ if (tableVersion.lesserThan(HoodieTableVersion.NINE)) {
+ Triple<RecordMergeMode, String, String> mergeConfigs =
+ HoodieTableConfig.inferCorrectMergingBehavior(
+ recordMergeMode, payloadClassName, recordMergerStrategyId,
preCombineField,
+ tableVersion);
+ tableConfig.setValue(RECORD_MERGE_MODE, mergeConfigs.getLeft().name());
+ tableConfig.setValue(PAYLOAD_CLASS_NAME.key(),
mergeConfigs.getMiddle());
+ tableConfig.setValue(RECORD_MERGE_STRATEGY_ID,
mergeConfigs.getRight());
+ } else {
+ Map<String, String> mergeConfigs = inferMergingConfigsForVersion9(
Review Comment:
The infer function in table 8 is way more complex than necessary. We should
simplify that for sure.
I will modify it to based on previous infer function for now since I want to
make it consistent with the upgrade logic.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1476,13 +1477,21 @@ public Properties build() {
tableConfig.setTableVersion(tableVersion);
tableConfig.setInitialVersion(tableVersion);
- Triple<RecordMergeMode, String, String> mergeConfigs =
- HoodieTableConfig.inferCorrectMergingBehavior(
- recordMergeMode, payloadClassName, recordMergerStrategyId,
preCombineField,
- tableVersion);
- tableConfig.setValue(RECORD_MERGE_MODE, mergeConfigs.getLeft().name());
- tableConfig.setValue(PAYLOAD_CLASS_NAME.key(), mergeConfigs.getMiddle());
- tableConfig.setValue(RECORD_MERGE_STRATEGY_ID, mergeConfigs.getRight());
+ if (tableVersion.lesserThan(HoodieTableVersion.NINE)) {
+ Triple<RecordMergeMode, String, String> mergeConfigs =
+ HoodieTableConfig.inferCorrectMergingBehavior(
+ recordMergeMode, payloadClassName, recordMergerStrategyId,
preCombineField,
+ tableVersion);
+ tableConfig.setValue(RECORD_MERGE_MODE, mergeConfigs.getLeft().name());
+ tableConfig.setValue(PAYLOAD_CLASS_NAME.key(),
mergeConfigs.getMiddle());
+ tableConfig.setValue(RECORD_MERGE_STRATEGY_ID,
mergeConfigs.getRight());
+ } else {
+ Map<String, String> mergeConfigs = inferMergingConfigsForVersion9(
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
