yihua commented on code in PR #13572:
URL: https://github.com/apache/hudi/pull/13572#discussion_r2233586688
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieFileGroupReaderOnFlink.java:
##########
@@ -176,23 +176,9 @@ public void assertRecordMatchesSchema(Schema schema,
RowData record) {
@Override
public HoodieTestDataGenerator.SchemaEvolutionConfigs
getSchemaEvolutionConfigs() {
HoodieTestDataGenerator.SchemaEvolutionConfigs configs = new
HoodieTestDataGenerator.SchemaEvolutionConfigs();
- configs.nestedSupport = false;
+ configs.supportBytesInArrayMap = false;
Review Comment:
Are these still not supported? Are they related to schema evolution?
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderOnJava.java:
##########
@@ -60,8 +60,6 @@ public void assertRecordMatchesSchema(Schema schema,
IndexedRecord record) {
@Override
public HoodieTestDataGenerator.SchemaEvolutionConfigs
getSchemaEvolutionConfigs() {
- HoodieTestDataGenerator.SchemaEvolutionConfigs configs = new
HoodieTestDataGenerator.SchemaEvolutionConfigs();
- configs.addNewFieldSupport = false;
- return configs;
+ return new HoodieTestDataGenerator.SchemaEvolutionConfigs();
Review Comment:
nit: Could we make this the default implementation in the base class
`TestHoodieFileGroupReaderBase`, and only override for Flink, which does not
support some evolution?
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieFileGroupReaderOnFlink.java:
##########
@@ -176,23 +176,9 @@ public void assertRecordMatchesSchema(Schema schema,
RowData record) {
@Override
public HoodieTestDataGenerator.SchemaEvolutionConfigs
getSchemaEvolutionConfigs() {
HoodieTestDataGenerator.SchemaEvolutionConfigs configs = new
HoodieTestDataGenerator.SchemaEvolutionConfigs();
- configs.nestedSupport = false;
+ configs.supportBytesInArrayMap = false;
Review Comment:
cc @danny0405 @cshuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
