the-other-tim-brown opened a new pull request, #13632:
URL: https://github.com/apache/hudi/pull/13632
### Change Logs
**Spark Changes:**
1. Introduces a more generic `SparkColumnarFileReader` trait to replace
`SparkParquetReader`. This is now provided to the Spark ReaderContext for
fetching the base file.
2. Adds a ORC implementation of `SparkColumnarFileReader` based on the
existing parquet reader implementations.
3. Adds a wrapper `SparkColumnarFileReader` that can hold both the ORC and
Parquet readers for the multi-format case
4. Removes `HoodieMultipleBaseFileFormat.scala` and renames
`HoodieFileGroupReaderBasedParquetFileFormat` to
`HoodieFileGroupReaderBasedFileFormat` as it is now generic and can process ORC
tables as well as the Multiple format tables.
**Testing Changes**
1. Added ORC base file tests for the Java, Flink, and Spark engines -
Hive+Hudi does not currently support ORC readers
2. Schema evolution testing is also updated with 1 caveat that the float to
string conversion testing is disabled due to precision issues in the ORC's
native schema evolution handling compared to our expectations.
### Impact
Ensures consistency across supported base file formats
### Risk level (write none, low medium or high below)
Low, test suites ensure consistent behavior after change
### Documentation Update
_Describe any necessary documentation update if there is any new feature,
config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
