danny0405 commented on code in PR #13631:
URL: https://github.com/apache/hudi/pull/13631#discussion_r2234249994
##########
hudi-common/src/main/java/org/apache/hudi/common/util/OrderingValues.java:
##########
@@ -27,7 +27,7 @@
* Factory class for ordering values.
*/
public class OrderingValues {
- private static final Comparable<?> DEFAULT_VALUE =
org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE;
+ public static final Comparable<?> DEFAULT_VALUE =
org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE;
Review Comment:
We make it private intentially and let's always use
`OrderingValues.getDefault()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
