danny0405 commented on code in PR #13603:
URL: https://github.com/apache/hudi/pull/13603#discussion_r2234445588
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -454,29 +457,26 @@ private boolean initializeFromFilesystem(String
dataTableInstantTime, List<Metad
String instantTimeForPartition =
generateUniqueInstantTime(dataTableInstantTime);
String partitionTypeName = partitionType.name();
LOG.info("Initializing MDT partition {} at instant {}",
partitionTypeName, instantTimeForPartition);
- String partitionName;
+ String relativePartitionPath;
Pair<Integer, HoodieData<HoodieRecord>> fileGroupCountAndRecordsPair;
- List<String> columnsToIndex = new ArrayList<>();
Lazy<Option<Schema>> tableSchema = Lazy.lazily(() ->
HoodieTableMetadataUtil.tryResolveSchemaForTable(dataMetaClient));
try {
switch (partitionType) {
case FILES:
fileGroupCountAndRecordsPair =
initializeFilesPartition(partitionIdToAllFilesMap);
- partitionName = FILES.getPartitionPath();
+ initializeFilegroupsAndCommitToMetadataPartition(partitionType,
FILES.getPartitionPath(), fileGroupCountAndRecordsPair,
instantTimeForPartition, Collections.emptyList());
Review Comment:
+1, the name is too long, or `initMetadataPartition` if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
