danny0405 commented on code in PR #13632:
URL: https://github.com/apache/hudi/pull/13632#discussion_r2234598999
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -110,7 +111,8 @@ private HoodieFileGroupReader(HoodieReaderContext<T>
readerContext, HoodieStorag
readerContext.setTablePath(tablePath);
readerContext.setLatestCommitTime(latestCommitTime);
boolean isSkipMerge = ConfigUtils.getStringWithAltKeys(props,
HoodieReaderConfig.MERGE_TYPE,
true).equalsIgnoreCase(HoodieReaderConfig.REALTIME_SKIP_MERGE);
-
readerContext.setShouldMergeUseRecordPosition(readerParameters.useRecordPosition()
&& !isSkipMerge && readerContext.getHasLogFiles());
+ boolean isParquetBaseFile =
inputSplit.getBaseFileOption().map(HoodieBaseFile::toString).map(path ->
path.endsWith(HoodieFileFormat.PARQUET.getFileExtension())).orElse(false);
Review Comment:
we can add a flag inside the InputSplit to holds the variable
`isParquetBaseFile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
