danny0405 commented on code in PR #13517:
URL: https://github.com/apache/hudi/pull/13517#discussion_r2238094065
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -336,4 +357,52 @@ protected static Option<IndexedRecord>
toAvroRecord(HoodieRecord record, Schema
return Option.empty();
}
}
+
+ /**
+ * Event time watermarker is tracked when
+ * 1. Record type is AVRO.
+ * 2. Event time ordering merge mode is used.
+ * 3. The flag is set.
+ */
+ boolean shouldTrackEventTimeWaterMarker(HoodieTableMetaClient metaClient,
+ HoodieWriteConfig config) {
+ return config.getRecordMerger().getRecordType() == AVRO
Review Comment:
why we limit the record type as avro, we have
`HoodieRecord.getColumnValueAsJava` to fetch the value directly which is more
efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
