danny0405 commented on code in PR #13635:
URL: https://github.com/apache/hudi/pull/13635#discussion_r2234356009


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -524,6 +524,6 @@ public Object get(String key) {
   }
 
   public enum HoodieRecordType {
-    AVRO, SPARK, HIVE, FLINK
+    AVRO, SPARK, HIVE, FLINK, AVRO_BINARY

Review Comment:
   We should still use `AVRO` record type instead of adding a new one, that is 
how we impl the record now, each engine has two format of record type, for 
Spark, it is `UnsafeInternalRow` and `SpecificInternalRow`, for Flink it is 
`BinaryRowData` and `GenericRowData`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to