leesf commented on a change in pull request #2278:
URL: https://github.com/apache/hudi/pull/2278#discussion_r536148844
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -789,6 +809,14 @@ public Long getMaxMemoryPerPartitionMerge() {
private boolean isConsistencyGuardSet = false;
private boolean isCallbackConfigSet = false;
+ public Builder() {
+ this(EngineType.SPARK);
+ }
+
+ public Builder(EngineType engineType) {
Review comment:
how about adding a method `withEngineType()` instead of making it a
`Builder` constructor param?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
