the-other-tim-brown opened a new pull request, #13653:
URL: https://github.com/apache/hudi/pull/13653

   ### Change Logs
   
   Restore planning:
   - the planning will now compute the instants to rollback based on the 
completion time of the commits instead of the requested time
   - there is one exception for tables with version less than 8 where a 
compaction started before an instant that we are restoring to must not be 
cleaned up since the log file is directly associate with that compaction instant
   - computing the files to delete now relies on the compaction metadata when 
the table version is 8 or greater or if the commit is a clustering commit
   
   Test Updates:
   - parameterized tests were added to existing flows
   - assertions were made on the record content instead of just counts which 
can mask issues with correctness
   - a check was added to ensure the metadata and file system are consistent
   - Cases were added for interleaved compaction and delta commits
   - Case was added for clustering followed by delta commit to ensure all files 
are properly cleaned up
   - RLI testing uses restore instead of rollback since the tests were 
attempting to rollback a clean commit which is a no-op
   
   ### Impact
   
   - Ensure restore behavior matches expectations and add testing to prevent 
possible regressions
   
   ### Risk level (write none, low medium or high below)
   
   Low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to