jonvex commented on code in PR #13628:
URL: https://github.com/apache/hudi/pull/13628#discussion_r2246201401


##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/common/table/read/HoodieFileGroupReaderOnJavaTestBase.java:
##########
@@ -113,4 +132,65 @@ public void commitToTable(List<HoodieRecord> recordList, 
String operation, boole
       }
     }
   }
+
+  @Override
+  public void commitSchemaToTable(InternalSchema schema, Map<String, String> 
writeConfigs, String historySchemaStr) {

Review Comment:
   This base class is in HoodieCommon so we don't have access to the write 
clients. Otherwise, I would prefer to do all writing in java so that we can 
test enums correctly etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to